Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intra-doc links using Markdown references get rendered incorrectly #11008

Closed
teohhanhui opened this issue Dec 14, 2021 · 6 comments
Closed

Intra-doc links using Markdown references get rendered incorrectly #11008

teohhanhui opened this issue Dec 14, 2021 · 6 comments
Labels
A-ide general IDE features C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@teohhanhui
Copy link

For example: https://github.com/rust-lang/rust/blob/7ca74ea0afe87b2cb173ea1fea190853c3c3d860/library/std/src/error.rs#L308

gets rendered as:
Screenshot from 2021-12-14 18-14-28

There are 2 problems here:

Converts a [str] into a box of dyn Error + Send + Sync.

and

[]: https://doc.rust-lang.org/nightly/alloc/str/index.html

rust-analyzer version: 7d6fcbc 2021-12-06 stable

rustc version: rustc 1.57.0 (f1edd0429 2021-11-29)
@Veykril Veykril added A-ide general IDE features C-bug Category: bug labels Dec 14, 2021
@palango

This comment has been minimized.

Sign in to view
@Veykril
Copy link
Member

Veykril commented Dec 14, 2021

That one is probably a different problem, the markdown for that is <code>[Vec]\<u8></code>. The first issue seems to be a problem with pulldown_cmark I think, or that using backticks in links is not valid cmark(don't know the spec too well).

The Vec issue I am not sure yet.

@palango
Copy link
Contributor

palango commented Dec 14, 2021

@Veykril Should I move this to a new issue then?

@Veykril
Copy link
Member

Veykril commented Dec 14, 2021

Sounds reasonable 👍

@palango palango mentioned this issue Dec 14, 2021
Open
@Veykril
Copy link
Member

Veykril commented Dec 17, 2021 •
edited
Loading

Okay checked a bit more thoroughly, this is indeed a bug in pulldown-cmark-to-cmark, I tink this is Byron/pulldown-cmark-to-cmark#20?

@Veykril Veykril added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Dec 17, 2021
@Isokaeder Isokaeder mentioned this issue Feb 6, 2022
Merged
bors bot added a commit that referenced this issue Feb 6, 2022
@bors
Merge #11418
d2d137a 
11418: fix: Update dependency, fix Markdown references r=Veykril a=HansAuger

Stumbled across this accidentally while familiarizing myself with the code base.

Update `pulldown-cmark-to-cmark` Fix for #11008  

Co-authored-by: Moritz Vetter <[email protected]>
@Veykril
Copy link
Member

Veykril commented Mar 6, 2022

Fixed in #11418

@Veykril Veykril closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ide general IDE features C-bug Category: bug S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palango @teohhanhui @Veykril