This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Prevent aggressive project rebuilding by retaining RUSTFLAGS order #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR fails on |
Xanewok
force-pushed
the
rustflags-rebuild-fix
branch
from
95f565d
to
e7d3330
Compare
|
Awesome, thanks! |
|
Is this fix in nightly builds yet? The bug is still reproduced with build |
|
@gentoo90 I don't think so. I just sent a PR to update the RLS submodule, so once that hits nightly it should be included (rust-lang/rust#42766). |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330. Thanks to @nrc's suggestion, using
BTreeMapinstead ofHashMapretains RUSTFLAGS order with which crate fingerprint has been made when compiling dep crates, thus not triggering complete project rebuild per each cargo run.