Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command improvements for ergonomics and error handling #3362

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Command improvements for ergonomics and error handling #3362

wants to merge 34 commits into from

Commits on Jan 3, 2023

  1. Propose Command improvements

    @ijackson
    ijackson committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    2a26454 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Apply rust tag to example 

    Co-authored-by: Lucius Hu <[email protected]>
    @ijackson @lebensterben
    ijackson and lebensterben authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9a4fc34 View commit details
    Browse the repository at this point in the history

  2. Discuss some alternatives around SubprocessError

    @ijackson
    ijackson committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    89705df View commit details
    Browse the repository at this point in the history

  3. Add rust tags to many other code blocks

    @ijackson
    ijackson committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    38b9c2a View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Use /nonexistent rather than /dev/enoent 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    2ff775e View commit details
    Browse the repository at this point in the history

  2. get_output gives one string, not a Vec 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    71583a4 View commit details
    Browse the repository at this point in the history

  3. get_output_line gives one string, not a Vec 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    30a0106 View commit details
    Browse the repository at this point in the history

  4. Fix typo 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    36b59ca View commit details
    Browse the repository at this point in the history

  5. Add lint suggestion to stderr handling default 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    57f63d7 View commit details
    Browse the repository at this point in the history

  6. Make SubprocessError be a transparent struct

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    bbd287d View commit details
    Browse the repository at this point in the history

  7. Promote just_status to current proposed, from future

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    79d0d25 View commit details
    Browse the repository at this point in the history

  8. Rename to read_stdout_*

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    84e4c78 View commit details
    Browse the repository at this point in the history

  9. Rename to ProcessError

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    92ef0e7 View commit details
    Browse the repository at this point in the history

  10. Document behaviour of read_stdout_line with no output at all

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d696820 View commit details
    Browse the repository at this point in the history

  11. Cross-reference for EOF and exit wait of read_stdout{,_line}

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    024e8ca View commit details
    Browse the repository at this point in the history

  12. Rename to ChildOutputStream

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    07ffa9f View commit details
    Browse the repository at this point in the history

  13. Move deprecation of .output() to Future possibilities

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    8e96f69 View commit details
    Browse the repository at this point in the history

  14. Document Error impl cause() behaviour

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    cd1c96d View commit details
    Browse the repository at this point in the history

  15. Discuss sensitive command line arguments

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    80f1496 View commit details
    Browse the repository at this point in the history

  16. Discuss combine-and-interleave of stdout and stderr

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    9d8a2a4 View commit details
    Browse the repository at this point in the history

  17. Use read_stdout for the bytes version

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    e16f199 View commit details
    Browse the repository at this point in the history

  18. Move read_stdout_line to Future possibilities

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    92ee567 View commit details
    Browse the repository at this point in the history

  19. Make error fields pub

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b8c623c View commit details
    Browse the repository at this point in the history

  20. Discuss status of the various ProcessError functions

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d94ad5d View commit details
    Browse the repository at this point in the history

  21. Make SubprocessError not be Clone

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    ac61312 View commit details
    Browse the repository at this point in the history

  22. Propose adding a docs warning to Command.output()

    @ijackson
    ijackson committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    732e555 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Fix typo 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    2292b56 View commit details
    Browse the repository at this point in the history

  2. Expand on reasoning for ProcessError::Default 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    9167ef5 View commit details
    Browse the repository at this point in the history

  3. Do a missed rename 

    Co-authored-by: Josh Triplett <[email protected]>
    @ijackson @joshtriplett
    ijackson and joshtriplett authored Jan 19, 2023
    Configuration menu
    Copy the full SHA
    561cb3f View commit details
    Browse the repository at this point in the history

  4. Slightly weaken assertion about stdout/stderr demux

    @ijackson
    ijackson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0103012 View commit details
    Browse the repository at this point in the history

  5. Add note about portability to comments about command lines

    @ijackson
    ijackson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    efa40c2 View commit details
    Browse the repository at this point in the history

  6. Expand on examples of why we want external ProcessError construction

    @ijackson
    ijackson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    37c4699 View commit details
    Browse the repository at this point in the history

  7. Introduce other_error replacing communication_error

    @ijackson
    ijackson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3f8db6e View commit details
    Browse the repository at this point in the history

  8. Introduce other_error replacing communication_error (clarify)

    @ijackson
    ijackson committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    a967e0f View commit details
    Browse the repository at this point in the history