-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move style guide #3320
Move style guide #3320
Conversation
Currently draft, until rust-lang/rust#102239 gets merged. |
I think we should definitely get rid of the specifics here as that's been an ongoing source of confusion. One of the things I heard when I first started contributing to rustfmt was that the rustfmt team of that time was entirely unaware that this rfc version of the style guide specifics existed here. |
I've a couple questions more related to the execution of moving the guide into r-l/rust that I'll ask here:
|
@calebcartwright Regarding your first and third points, RFC 3309 mentions:
I think we should keep fmt-rfcs for now, and decide as a team if we want to continue using it or use some other process for larger pieces of style work. |
@calebcartwright wrote:
We've talked about having a similar FAQ for other frequently requested items, such as "make braces optional on |
RFC 3309 moved the style guide to `rust-lang/rust`. In addition, the link from [RFC 2436](https://rust-lang.github.io/rfcs/2436-style-guide.html) to the style guide does not seem to have ever worked, and the style guide has never been available anywhere in rendered form. Update RFC 2436 minimally to point to the rendered style guide.
802f8c8
to
ae5c286
Compare
rust-lang/rust#102239 has been merged, so this can now be merged as well. |
RFC 3309 moved the style guide to
rust-lang/rust
. In addition, thelink from
RFC 2436 to
the style guide does not seem to have ever worked, and the style guide
has never been available anywhere in rendered form.
Update RFC 2436 minimally to point to the rendered style guide.
Rendered