-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Backtrace in core #3156
RFC: Backtrace in core #3156
Conversation
Co-authored-by: Nick Cameron <[email protected]>
#[cfg(not(bootstrap))] | ||
extern "Rust" { | ||
#[lang = "backtrace_create"] | ||
fn backtrace_create(ip: usize) -> *mut dyn RawBacktrace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrc I don't think we can use Box
with this destined for core. Also, I'm not sure what you mean by impl Backtrace
here. If you mean fn backtrace_create(ip: usize) -> impl Backtrace
then I'd be surprised if that works, though I'm not super experienced with extern "Rust"
so maybe its fine to have a generic type here.
Co-authored-by: Jane Lusby <[email protected]> Co-authored-by: Nick Cameron <[email protected]>
What's the current status of this RFC? |
The current status is that we don't intend to merge this RFC. It was written as one of the potential paths to moving error into core assuming generic member access didn't work out but at this point it seems extremely likely that we will merge the generic member access RFC once we finish the provider RFC. That RFC provides a superset of the functionality provided by For context: |
@yaahc shall we close it, then? |
Rendered
Based on
Backtrace
incore
PR.Remaining concerns:
impl Backtrace
return type works withbacktrace_create()
Backtrace
type - increase size from 1 word to 2 wordsstruct
instead oftrait