Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo report future-incompat #2834

Merged
merged 19 commits into from
Apr 17, 2020
Merged

Cargo report future-incompat #2834

merged 19 commits into from
Apr 17, 2020

Commits on Dec 10, 2019

  1. RFC text ready for posting.

    @pnkfelix
    pnkfelix committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    63c7af9 View commit details
    Browse the repository at this point in the history

  2. Changed running example for 3rd time. Added cap-lints extension discu… 

    …ssion.
    @pnkfelix
    pnkfelix committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    bc69978 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Eric Huss <[email protected]>
    @pnkfelix @ehuss
    pnkfelix and ehuss authored Dec 11, 2019
    Configuration menu
    Copy the full SHA
    f2733fc View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Remove digression regarding behavior of path-dependencies; it no long… 

    …er occurs on nightly.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    4126f2d View commit details
    Browse the repository at this point in the history

  2. Soften language regarding compiler and lang teams' conservatism.

    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    8f4583f View commit details
    Browse the repository at this point in the history

  3. Lighten policy language; do not mention editions or other alternative… 

    … mechanisms.

Just state that I do not intend for us to blindly convert every future
incompat lint to use this system.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    571478e View commit details
    Browse the repository at this point in the history

  4. Revise version-querying suggestion to suggest index query first 

    before discussing anything with crates.io.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    5d4d98c View commit details
    Browse the repository at this point in the history

  5. s@build/@target/@. 

    Also, fixed some text that clearly dates from the now-irrelevant issues
we used to have with diagnostics on path-dependencies.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    4c77d94 View commit details
    Browse the repository at this point in the history

  6. Cargo already has turned on error-format=json by default. 

    So get rid of text wondering about making that a step in the implementation strategy.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    6e1bb2d View commit details
    Browse the repository at this point in the history

  7. Add note about rustc --json CONFIG to the implementation questions … 

    …section.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    c862283 View commit details
    Browse the repository at this point in the history

  8. Add note about needing to include info about specific versions when n… 

    …ecessary.
    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    90415f8 View commit details
    Browse the repository at this point in the history

  9. fix typos.

    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    64d1f9f View commit details
    Browse the repository at this point in the history

  10. fix typo.

    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    65f5d53 View commit details
    Browse the repository at this point in the history

  11. Add section on annoyance modulation.

    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    7bebac8 View commit details
    Browse the repository at this point in the history

  12. fix typo.

    @pnkfelix
    pnkfelix committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    14bd7f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. add explicit note that this change does not effect existing `-Dwarnin… 

    …gs` usage.
    @pnkfelix
    pnkfelix committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    4a737c4 View commit details
    Browse the repository at this point in the history

  2. Tried to add text addressing alex's concern about our policy for when… 

    … these get turned on.
    @pnkfelix
    pnkfelix committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    93532af View commit details
    Browse the repository at this point in the history

  3. Address review concern, clarifying interaction with -Dwarnings.

    @pnkfelix
    pnkfelix committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    2241fa7 View commit details
    Browse the repository at this point in the history

  4. Update 0000-cargo-report-future-incompat.md

    @pnkfelix
    pnkfelix authored Feb 7, 2020
    Configuration menu
    Copy the full SHA
    1f5a1eb View commit details
    Browse the repository at this point in the history