Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ergonomic format_args! #1618

Merged
merged 3 commits into from
Jun 24, 2016
Merged

Ergonomic format_args! #1618

merged 3 commits into from
Jun 24, 2016

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented May 17, 2016

Rendered.

This describes rust-lang/rust#33642 (minus the TODO bits of course). Hopefully the distinction of macro arguments, placeholders and generated argument objects is made clear...

Note: My native language is not English, so although I've already proofread the draft please do note any English-related issues as well for minimizing confusion.

@nrc nrc added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label May 18, 2016
@alexcrichton
Copy link
Member

Thanks for the PR and RFC! I personally feel like this change would largely just be a bug fix so it may not require an RFC, but we can probably reach a conclusion in the libs team pretty quickly regardless.

@alexcrichton alexcrichton mentioned this pull request May 20, 2016
Merged
@alexcrichton alexcrichton self-assigned this May 20, 2016
@alexcrichton
Copy link
Member

🔔 This RFC is now entering its week-long final comment period 🔔

The libs team at triage was at least all in favor of this, seems like a great with with no downsides!

@alexcrichton alexcrichton added the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label May 24, 2016
@alexcrichton
Copy link
Member

Ok, the libs team got a chance to discuss this RFC yesterday and the conclusion was that we'd like to merge. The RFC, however, may be going a bit too much into detail of how the implementation works (and is maybe even out of date already?). @xen0n would you be ok updating the text to explain mostly at a high level what's happening here? Basically just that format!("{0:x} {0:o}", ...) will basically start working and the compiler will do things like ensure it doesn't evaluate expressions twice.

@xen0n
Copy link
Contributor Author

xen0n commented Jun 21, 2016

@alexcrichton Sure, will update the text later. It's a bit late here. 😄

@xen0n
ergonomic-format-args: address review comments
89002e7 
* feature name seems not applicable as this is not something to be gated
* updated to reflect latest implementation
* removed most details for higher-level overview
* reworded slightly
@alexcrichton
Copy link
Member

Awesome, thanks again @xen0n!

@alexcrichton alexcrichton merged commit 89002e7 into rust-lang:master Jun 24, 2016
@chriskrycho chriskrycho mentioned this pull request Dec 31, 2016
Closed
17 tasks
@chriskrycho chriskrycho mentioned this pull request Mar 11, 2017
Closed
48 tasks
@Centril Centril added A-macros-libstd Proposals that introduce new standard library macros A-fmt Proposals relating to std::fmt and formatting macros. labels Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
A-fmt Proposals relating to std::fmt and formatting macros. A-macros-libstd Proposals that introduce new standard library macros final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xen0n @alexcrichton @nrc @Centril