syntax: fix interval set optimizations #1104
Draft
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `push` function in rust-lang#1051
|
I think you'll want to rebase on master. Given the bugs the last optimizations caused, it's clear that the tests covering these operations are insufficient. Since this code is incredibly subtle, I have to insist that we improve our testing strategy before we start overhauling how these ops are implemented. |
|
Indeed, maybe I gotta design some more delicate test cases for those functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refractor the
pushfunction in #1051.This fix the bug found in #1103 and #1102 based on commit 6d2b09e.