Items chapter cleanup and improvements #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the list at the start of the chapter be in the same order as the actual chapter * Say some more about C like enums * Make the wrapping more consistent * Fix some header levels * Make more of the code examples tested * Be a bit clearer on RFC 116
Havvy
reviewed
Aug 9, 2017
src/items.md
Outdated
| [path]: paths.html | ||
| [modules]: #modules | ||
| [blocks]: ../grammar.html#block-expressions | ||
| [path]: paths.html [modules]: #modules [blocks]: |
There was a problem hiding this comment.
Doesn't this break the links?
Havvy
reviewed
Aug 9, 2017
src/items.md
Outdated
|
|
||
| [struct type]: types.html#struct-types | ||
| [tuple type]: types.html#tuple-types | ||
| [struct type]: types.html#struct-types [tuple type]: types.html#tuple-types |
There was a problem hiding this comment.
Same here with does this actually break links? We probably want them on multiple lines even if they don't.
|
LGTM minus the two comments. |
matthewjasper
force-pushed
the
items-cleanup
branch
from
88b90fe
to
2f04efa
Compare
matthewjasper
force-pushed
the
items-cleanup
branch
from
2f04efa
to
7c8ff20
Compare
|
This LGTM too; a small rebase is needed due to a grammar PR; ping me when you've rebased and I will merge! |
|
@steveklabnik this should now be good to go. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes (mostly) small improvements to the items chapter