Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of RFC 2128 (use_nested_groups) in the reference #230

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Add mention of RFC 2128 (use_nested_groups) in the reference #230

merged 1 commit into from
Feb 6, 2018

Conversation

pietroalbini
Copy link
Member

The feature use_nested_groups will soon be stabilized, and this PR adds a mention of it in the reference.

This only adapts the current reference to be coherent with the new implementation, but it doesn't add a dedicated section about it. If that's something we want I can work on it (but I don't think it's really needed).

This fixes #225, tracking issue rust-lang/rust#44494

@alercah alercah added the RFC Stabilization Docs Documentation required for stabilizing a feature label Feb 1, 2018
@matthewjasper matthewjasper added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Feb 1, 2018
@matthewjasper
Copy link
Contributor

LGTM, do you want to adjust the syntax at the top of this page as well?

@pietroalbini
Copy link
Member Author

Sure, added the new syntax at the top.

`use a::b::*;`
`use a::b::*;`.
* Nesting groups of the previous features multiple times, such as
`use a::b::{self as ab, c d::{*, e::f}};`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a :: or , between c and d.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One typo that I missed last time.

@matthewjasper matthewjasper merged commit e2d1ee5 into rust-lang:master Feb 6, 2018
@matthewjasper
Copy link
Contributor

Thanks!

@pietroalbini pietroalbini deleted the use-nested-groups-reference branch February 6, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Stabilization Docs Documentation required for stabilizing a feature S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document RFC 2128
3 participants