-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document inclusive ranges. #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. The ...
operator in the precedence table (expressions.md) also needs to be changed to ..=
. Otherwise LGTM.
Will there be a stabilization PR for this soon?
src/expressions/match-expr.md
Outdated
``` | ||
|
||
Other forms of [range] \(`..` for an exclusive range, or any range with one or | ||
both endpoints left unspecified) are not currently supported in matches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that 'currently' is needed, the reference only talks about Rust at this point in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I also remarked that ...
is still accepted for backwards compatibility.
According to rust-lang/rust#28237, all that's left is docs, so hopefully once all my doc PRs are good it will be ready to go. |
Note that the failing build is due to using an un-stabilized feature; it should pass once the feature is stabilized and released. |
|
f64fd58
to
547305f
Compare
Done. |
This just landed as stable in nightly. Let's restart travis! |
🎊 |
Provides the reference documentation for rust-lang/rust#28237.