Loops grammar #139
Merged
Loops grammar #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/expressions/loop-expr.md
Outdated
| A `while let` loop is semantically similar to a `while` loop but in place of a | ||
| condition expression it expects the keyword `let` followed by a refutable | ||
| pattern, an `=` and an expression. If the value of the expression on the right | ||
| pattern, an `=` and a block expression. If the value of the expression on the right |
There was a problem hiding this comment.
...an =, an expression and a block expression.
Havvy
reviewed
Oct 16, 2017
src/expressions/loop-expr.md
Outdated
| @@ -44,10 +67,15 @@ while i < 10 { | |||
|
|
|||
| ## `while let` loops | |||
|
|
|||
| > **<sup>Syntax</sup>** | |||
| > [_WhileLetExpression_] : | |||
| > `while` `let` _Pattern_ `=` [_Expression_]<sub>except struct expression</sub> | |||
There was a problem hiding this comment.
All of the other loop expressions are named after what they do. So shouldn't this one be called PredicatePatternLoopExpression?
Havvy
reviewed
Oct 16, 2017
| @@ -61,6 +89,11 @@ while let Some(y) = x.pop() { | |||
|
|
|||
| ## Iterator loops | |||
|
|
|||
| > **<sup>Syntax</sup>** | |||
| > _IteratorLoopExpression_ : | |||
| > `for` _Pattern_ `in` [_Expression_]<sub>except struct expression</sub> | |||
There was a problem hiding this comment.
Like if, we probably want to link to struct expressions here.
There was a problem hiding this comment.
Still deciding how I'll do this (the "no struct expression" thing) to make it clear. But yeah, I agree a link to it will be needed.
brauliobz
force-pushed
the
grammar_loop_expr
branch
from
e02b4da
to
413fe21
Compare
Havvy
approved these changes
Dec 1, 2017
|
💟 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #84.