Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl std::simd::StdFloat #219

Merged
merged 2 commits into from
Dec 31, 2021
Merged

impl std::simd::StdFloat #219

merged 2 commits into from
Dec 31, 2021

Commits on Dec 31, 2021

  1. impl std::simd::StdFloat 

    While consulting with Simulacrum on how to make available the float
functions that currently require runtime support for `Simd<f32, N>` and
`Simd<f64, N>`, we realized breaking coherence with the classic approach
of lang items was, since `{core,std}::simd::Simd` is a `ty::Adt`, likely
to be quite a bit nasty. The project group has a long-term plan for how
to get around this kind of issue and move the associated functions into
libcore, but that will likely take time as well. Since all routes
forward are temporally costly, we probably will skip the lang item
approach entirely and go the "proper" route, but in the interests of
having something this year for people to play around with, this
extension trait was whipped up.

For now, while it involves a lot of fairly internal details most users
shouldn't have to care about, I went ahead and fully documented the
situation for any passerby to read on the trait, as the situation is
quite unusual and puzzling to begin with.
    @workingjubilee
    workingjubilee committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    ecc00ef View commit details
    Browse the repository at this point in the history

  2. Tear down and rewrite support for float testing

    @workingjubilee
    workingjubilee committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    af26e3b View commit details
    Browse the repository at this point in the history