Don't append .lib suffix on MSVC builds #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc already does that itself. As such, the only difference between MSVC and other platforms is to skip a couple of libraries that are often wrongly added by pkg-config.
This was referenced Aug 28, 2018
|
Confirmed to fix the servo build |
|
👍 |
|
Sorry for missing that last time! Would be a good time for a release again now :) and then I'll also get rid of those workarounds in the gtk-rs -sys crates. |
|
Sure thing, done now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc already does that itself. As such, the only difference between
MSVC and other platforms is to skip a couple of libraries that are often
wrongly added by pkg-config.
This didn't cause problems for me in the past because of https://github.com/gtk-rs/sys/blob/cdc7f613c2ed1e4f021a2c83d6f51469edc03eb1/glib-sys/build.rs#L66 and similar code.
Also e.g. rust-lang/libz-sys@d520341 should IMHO be reverted (and there the workaround for macOS is going to cause problems too)