Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update casts.md #256

Closed
wants to merge 1 commit into from
Closed

Update casts.md #256

wants to merge 1 commit into from

Conversation

egdeeno
Copy link

@egdeeno egdeeno commented Jan 22, 2021

casting inf and -inf to integer

@egdeeno
Update casts.md
1786369 
casting inf and -inf to integer
Havvy
Havvy reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just repeats of the previous two bullets before NaN but using specific values. Perhaps put "including inf" and ", including -inf" in those bullets instead?

@egdeeno
Copy link
Author

egdeeno commented Jan 22, 2021 •
edited
Loading

Perhaps put "including inf" and ", including -inf" in those bullets instead?

maybe

@JohnTitor
Copy link
Member

@edgeone89 Ping, could you address @Havvy's comment? Thanks!

@JohnTitor JohnTitor mentioned this pull request Jun 29, 2021
Merged
@ehuss ehuss closed this in #287 Jul 1, 2021
@JohnTitor JohnTitor mentioned this pull request Jul 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havvy Havvy Havvy left review comments

Assignees
No one assigned
Labels
waiting-on-author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egdeeno @JohnTitor @Havvy