add support for pclmulqdq intrinsic
#3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
add-pclmulqdq
branch
3 times, most recently
from
61312da
to
2266db9
Compare
folkertdev
changed the title
pclmulqdqpclmulqdq intrinsic
|
@rustbot ready |
RalfJung
reviewed
Jun 8, 2024
There was a problem hiding this comment.
Thanks for the PR!
is my method for decomposing a __m128i into two separate i64 values allright?
A transmute is one option; just accessing the two fields would also work but would rely on the way that type is declared. I think we already have similar transmutes for other x86 intrinsics, so this is fine.
|
@rustbot author |
rustbot
added
S-waiting-on-author
folkertdev
force-pushed
the
add-pclmulqdq
branch
2 times, most recently
from
b580ae6
to
0652638
Compare
RalfJung
reviewed
Jun 8, 2024
RalfJung
reviewed
Jun 8, 2024
folkertdev
force-pushed
the
add-pclmulqdq
branch
2 times, most recently
from
1dcc98b
to
9a5cce7
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
In future please avoid force-pushing (except when there are conflicts that need resolving) until the PR is done. Github is pretty bad at keeping track of force-pushes, making it basically impossible to tell what changed since my last review. |
RalfJung
reviewed
Jun 8, 2024
|
Thanks. :-) @bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instruction is required in fast implementations of the crc32 checksum algorithm, and used in the https://crates.io/crates/crc32fast and https://crates.io/crates/zlib-rs crates.
Some questions from my side
__m128iinto two separatei64values allright?