-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix MiriAllocBytes
to guarantee different addresses
#3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"overlap" isn't quite right, since arguably ranges with with size 0 can never overlap. But two different allocations can end up at the same address, and that's a problem. |
RalfJung
reviewed
May 23, 2024
RalfJung
reviewed
May 23, 2024
RalfJung
reviewed
May 23, 2024
Strophox
changed the title
Bugfix
Bugfix May 23, 2024
MiriAllocBytes
overlapping addressesMiriAllocBytes
to guarantee different addresses
but this surprisingly failed all tests:
Why did they fail? Setting the size to 1 should work and avoids duplicating logic so please figure out why it did not work.
|
RalfJung
reviewed
May 24, 2024
RalfJung
reviewed
May 24, 2024
RalfJung
reviewed
May 24, 2024
@bors r+ |
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in
alloc_bytes.rs
following #3526Currently when an allocation of
size == 0
is requested we return astd::ptr::without_provenance_mut(align)
, but this means returnedptr
s may overlap, which breaks things.