Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'missing extern static' error consistent with missing shim #3455

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 6, 2024

What's relevant is mostly the link name of the external symbol, not its Rust path.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 6, 2024

📌 Commit 52a66b2 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 6, 2024

⌛ Testing commit 52a66b2 with merge f70a3c4...

@bors
Copy link
Contributor

bors commented Apr 6, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing f70a3c4 to master...

@bors bors merged commit f70a3c4 into rust-lang:master Apr 6, 2024
8 checks passed
@RalfJung RalfJung deleted the extern-static branch April 6, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants