Don't explicitly warn against semicolon_in_expressions_from_macros
#3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warns-by-default since 2 years and already has been added to the future-incompat group since Rust 1.68. See rust-lang/rust#79813 for the tracking issue.
|
Thanks for the PR! Funny that it insists on formatting only after the line got shorter... that makes no sense, does it? Looks like a rustfmt bug to me. This is taken directly from bootstrap, I guess they don't need this flag any more either then? |
|
☀️ Test successful - checks-actions |
|
It was weird, indeed! Maybe it only checks for the modified lines? In any case, didn't want to wrestle Rustfmt here 😄 I've also opened rust-lang/rust#118642 to remove the warning argument in bootstrap. |
|
No, rustfmt will always check the entire file. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warns-by-default since 2 years and already has been added to the future-incompat group since Rust 1.68.
See rust-lang/rust#79813 for the tracking issue.
Just something I noticed when trying to wrap my head around lints warned against in the rust-lang/rust and noticed it's not warned against anymore; let me know if the change makes sense 🙏