Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more validation tests #315

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Enable more validation tests #315

merged 2 commits into from
Aug 28, 2017

Conversation

RalfJung
Copy link
Member

rust-lang/rust#43457 got fixed :)

@oli-obk
Copy link
Contributor

oli-obk commented Aug 28, 2017 •
edited
Loading

I have no idea why some of the tests are still failing... It works locally, but doesn't work on travis. Nevermind, these tests just don't work with full mir + validation

@oli-obk
Copy link
Contributor

oli-obk commented Aug 28, 2017

Let's turn validation back off for these tests.

@RalfJung
Copy link
Member Author

RalfJung commented Aug 28, 2017 •
edited
Loading

Thanks, that looks right. I have an idea for how to fix #296; once I implemented that, I can reevaluate these tests.

@RalfJung
Copy link
Member Author

The one thing I do not understand at all is undefined_byte_read.rs. That one still works on master (the CRON job just accepted it), but it failed here?

@RalfJung
Copy link
Member Author

Turns out that was just a fluke on my end. I removed that commit.

@oli-obk oli-obk merged commit b93462a into rust-lang:master Aug 28, 2017
@RalfJung RalfJung mentioned this pull request Aug 28, 2017
Merged
@RalfJung RalfJung deleted the validation branch August 29, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RalfJung @oli-obk