Ignore symbol shim clash when symbol is provided by compiler_builtins #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this happens, we ignore the symbol from `compiler_builtins` in favor of Miri's builtin support. This allows Miri to target platforms like wasm32-unknown-unknown, where functions like `memcmp` are provided by `compiler_builtins`.
|
Makes sense, thanks! |
|
☀️ Test successful - checks-actions |
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 9, 2023
update Miri Notable PRs: - rust-lang/miri#2748 - rust-lang/miri#2752 r? `@ghost`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Jan 13, 2023
update Miri Notable PRs: - rust-lang#2748 - rust-lang#2752 r? `@ghost`
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
update Miri Notable PRs: - rust-lang/miri#2748 - rust-lang/miri#2752 r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this happens, we ignore the symbol from
compiler_builtinsin favor of Miri's builtin support.
This allows Miri to target platforms like wasm32-unknown-unknown,
where functions like
memcmpare provided bycompiler_builtins.