make unix path handling on Windows hosts (and vice versa) preserve absoluteness #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
host-to-target-path
branch
from
0e40664 to
d98d5d0
Compare
RalfJung
changed the title
RalfJung
force-pushed
the
host-to-target-path
branch
from
d4c500e to
1872101
Compare
RalfJung
force-pushed
the
host-to-target-path
branch
6 times, most recently
from
791ba57 to
abce83a
Compare
|
This seems to actually work. :) @rust-lang/miri are you fine with this patch or is it too terrible of a hack?^^ |
RalfJung
force-pushed
the
host-to-target-path
branch
2 times, most recently
from
fbdc0c2 to
dab02cc
Compare
RalfJung
changed the title
RalfJung
force-pushed
the
host-to-target-path
branch
3 times, most recently
from
105eeb5 to
03eee6b
Compare
- test that the tmpdir Miri tests see is absolute and a directory - test that current_dir returns an absolute path
RalfJung
force-pushed
the
host-to-target-path
branch
2 times, most recently
from
c2a31c8 to
038117c
Compare
RalfJung
force-pushed
the
host-to-target-path
branch
from
038117c to
03f1ce4
Compare
|
The duplication in the tests is annoying, but that's a separate issue we have with all of those extern C miri helpers. lgtm! |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2022
update Miri Noteworthy PRs: - rust-lang/miri#2357 - rust-lang/miri#2646 - rust-lang/miri#2718 - rust-lang/miri#2721 - rust-lang/miri#2725
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Dec 28, 2022
update Miri Noteworthy PRs: - rust-lang#2357 - rust-lang#2646 - rust-lang#2718 - rust-lang#2721 - rust-lang#2725
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
update Miri Noteworthy PRs: - rust-lang/miri#2357 - rust-lang/miri#2646 - rust-lang/miri#2718 - rust-lang/miri#2721 - rust-lang/miri#2725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a magic Miri extern function so this conversion can be invoked by the program. That avoids having to duplicate that logic.