Allow backends to cache previous results #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I understand this, and it does seem to make sense. It was already documented in the paragraph above that it may exist for caching, though emphasizing it twice doesn't hurt. 😉 |
|
Deleting the book dir also removes any files written to the book output directory by preprocessors, which seems a bit too rigorous. See issue #1087 |
This was referenced Aug 22, 2020
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Allow backends to cache previous results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that came up in my rewrite of
mdbook-linkcheck(Michael-F-Bryan/mdbook-linkcheck#11). I'd implemented a cache so we don't execute lots of slow web requests too frequently, and found that the cache file didn't exist every time themdbook-linkcheckbackend was invoked.We probably want to let backends cache previous results. This PR removes the call to
utils::fs::remove_dir_content(&build_dir)inMDBook::build()and makes sure the the HTML renderer manually cleans its destination directory.I've also updated the user-docs to mention this.