Add Ayu theme
#315
Merged
Add Ayu theme
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds the a new variable, `$inline-code-color`, to base.styl. The `Ayu` theme needed this to change the text color of inline code.
|
Looks very nice! Thank you 😊 I will take a look at this PR when I have more time, but from a quick glance through the changes everything looks fine to merge. |
|
Merged. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223.
I finally got this done! Here is a comparison between the new theme (left) and the Navy theme (right):
The only modification I had to make to mdBook itself (beyond the addition of the theme throughout the codebase, of course) was to introduce a variable so that I could change inline code's text color. If you don't want this it can certainly be removed (although I feel that it makes the theme more readable).
And finally, to be clear: if you don't feel like mdBook should ship with this theme, feel free to say so. I'm not trying to force it on anyone :)