Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use embedded Font Awesome SVG icons #2484

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use embedded Font Awesome SVG icons #2484

wants to merge 5 commits into from
+218 −2,754

Conversation

uncenter
Copy link

Incorporates the changes from #1330, brings up to date with repository and adds various fixes & improvements.

@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Nov 15, 2024
notriddle
notriddle reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's a good idea to try to work around this, but existing books are going to be written to the old fontawesome version.

src/renderer/html_handlebars/helpers/fontawesome.rs Show resolved Hide resolved
src/renderer/html_handlebars/hbs_renderer.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uncenter @notriddle @rustbot