Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchors #211 #212

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Fix anchors #211 #212

merged 2 commits into from
Feb 28, 2017

Conversation

azerupi
Copy link
Contributor

@azerupi azerupi commented Feb 24, 2017

This should fix #211

\cc @steveklabnik

You can merge this, unless you have a cleaner way to solve this :)

@elinorbgr
Copy link

#211 also manifest itself on footnotes which links on <a href='#1'>...</a> for example. I may be misunderstanding, but it looks like this PR only handles titles?

@azerupi
Copy link
Contributor Author

azerupi commented Feb 24, 2017

Ah, thanks for mentioning ! I will take a look at footnotes later today :)

@steveklabnik
Copy link
Member

so, azerupi@d609988 was the JS code that was removed, and this was only for headers. My PR didn't touch footnotes, or at least, not that I'm aware.

The bug happened because the JS did $(location).attr('href').split("#")[0] + "#" + header_name and I missed the first part, I guess ☹️

@steveklabnik
Copy link
Member

Anyway, looks good to me, I think this is the cleanest way ❤️

@azerupi
Copy link
Contributor Author

azerupi commented Feb 28, 2017

This should now fix all anchors. It's not the most elegant solution, but it's functional.

@steveklabnik
Copy link
Member

It looks like travis is just broken, i might investigate tomorrow. All prs are failing the same way.

@azerupi
Copy link
Contributor Author

azerupi commented Feb 28, 2017

Yes, there is definitely something wrong with the Travis builds. :/

@azerupi azerupi merged commit e5a973a into master Feb 28, 2017
@azerupi azerupi deleted the fix-anchors branch April 15, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<base href="../"> messes with anchor links
3 participants