Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print icon. #1335

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Fix print icon. #1335

merged 1 commit into from
Sep 22, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 22, 2020

I accidentally missed that the logic was reversed in #1169.

@ehuss ehuss merged commit d0deee9 into rust-lang:master Sep 22, 2020
@kalindkaria
Copy link

kalindkaria commented Sep 22, 2020

@ehuss Sorry to bother you again.
As you mentioned in #1169 I pulled and checked but can still see the printer icon. Don't know I might be wrong.
Can you please check at your end once and confirm.
Thanks.

@ehuss
Copy link
Contributor Author

ehuss commented Sep 22, 2020

Hm, seems to work form me:

output.html.print.enable = true (default):
image

output.html.print.enable = false:
image

This is with d0deee9. Maybe check that you have the right version and the syntax in book.toml is correct?

@kalindkaria
Copy link

Yes, really sorry to ask this.
I had my custom theme folder in book.toml. I disabled it and it worked well.
Thanks alot.
I think #1169 can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants