-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove google fonts by serving them locally #1188
Conversation
Thanks for picking this up! Just a few small things, and I think I'd be happy merging this:
|
Co-authored-by: Aral Balkan <[email protected]> Co-authored-by: Collyn O'Kane <[email protected]>
Hey! First of all, I didn't want the .woff files to end up in the git history (as they sum more than 500 kB) and the commits were very confusing, so I just force pushed a single simpler commit with the authors of both #848 and #1189 as co-authors. Addressing your points:
What do you think? |
How about using |
Ah, good catch! I think I would prefer to avoid the |
I would prefer not to have a network dependency like that. |
Great! In the next few days I'll fix this. |
Done! I also forgot to copy the fonts' licenses themselves to the output directory, which is now fixed 😅 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the help!
Remove google fonts by serving them locally
This is #848 +
Fixes #847
I may also remove the .woff variants as the only current browser that doesn't support it is IE, which would anyway fallback to sans-serif.
I propose that we first fix this long standing issue and then add an option to make these fonts optional for those that use custom themes, for example.
@ehuss can you give me your thoughts?
Thanks!