Scroll sidebar to middle instead of top. #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dylan-DPC what do you think? I kinda like having it scroll to the middle of the page, where you can see the pages just before and after where you currently are. But the preference is somewhat arbitrary. I tested on a variety of browsers, and it seems to work well. Some older browsers, like Edge, don't support the "center" property, but do support scrolling, and it scrolls to the top of the page like it does today. |
|
I like the idea. Thanks. Merging! (sorry didn't realise I was pinged :D ) |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
* Fix: Scroll sidebar to current active section (rust-lang#1067) * Clean: Some code related to PR rust-lang#1052 * Change `scrollIntoViewIfNeeded` with `scrollIntoView` * Don't use onload event for sidebar scroll to reduce flickering. Co-authored-by: 李鸿章 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submission of #1068. It changes the side bar so that the current page is in the vertical center instead of the top of the window. From the previous PR, I removed the onload event handler since it caused some jumping, and it doesn't seem to be necessary.