-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Improve crate compilation times #1076
WIP: Improve crate compilation times #1076
Conversation
After updating I'm guessing the compilation improvements are because we aren't compiling multiple versions of the same crate. |
Thanks! Looks like it bumps msrv to 1.37 (I think)? Would be fine with me. |
For some reason, removing the itertools crate (it was only used two or three times to skip an allocation when concatenating lines) and running I don't think New dependency graph: |
@ehuss yeh most likely this will be a breaking change so might as well release a new major version when finished which would also justify the msvr bump |
I just removed New dependency graph: Timings: remove-toml-query.zip |
I swapped out iron with simple-server and the "build" stage in CI went from 4 mins 1 second to 3 mins 52 seconds. Timings: |
@Michael-F-Bryan Is this ready to go? You still have WIP in the title. I really like the changes, and it looks good to go to me. |
I'm not certain it makes much of a difference. When running on my laptop I found the results super noisy and inconsistent, and I wasn't confident the compile time improvements weren't just due to something like the page cache or CPU governor changing clock frequency... |
Thanks for getting this going! Closed via #1211. |
Hopefully this will make improvements towards #1017. As I'm going I'll try to post numbers so we can see how changes affect compilation times.
Initial breakdown of compilation times using
cargo build -Ztimings
:timings.zip