Option to display copy buttons. #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added field to playpen data structure - Communicate through window.playpen_copyable - Javascript updated to check before displaying copy buttons.
weihanglo
suggested changes
Oct 16, 2019
src/config.rs
Outdated
| @@ -476,6 +476,8 @@ impl HtmlConfig { | |||
| pub struct Playpen { | |||
| /// Should playpen snippets be editable? Default: `false`. | |||
| pub editable: bool, | |||
| /// display the copy button | |||
There was a problem hiding this comment.
Uppercase the first letter might be better and more consistent across comments. Also, we love to document default values especially when it is not the default of that type.
Suggested change
| /// display the copy button | |
| /// Display the copy button. Default: `true`. |
| @@ -445,6 +445,9 @@ fn make_data( | |||
| data.insert("playpen_line_numbers".to_owned(), json!(true)); | |||
| } | |||
| } | |||
| if html.playpen.copyable { | |||
There was a problem hiding this comment.
It should be html_config.
Suggested change
| if html.playpen.copyable { | |
| if html_config.playpen.copyable { |
Also: - update description of copyable in source code. - update description of line_numbers (my last PR to this repository)
weihanglo
approved these changes
Oct 16, 2019
|
Thank you! |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
* Option to display copy buttons. - Added field to playpen data structure - Communicate through window.playpen_copyable - Javascript updated to check before displaying copy buttons. * html -> html_config Also: - update description of copyable in source code. - update description of line_numbers (my last PR to this repository)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043