Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue hover in sidebar does not work. #826

Closed
donald-pinckney opened this issue Nov 15, 2018 · 0 comments
Closed

Blue hover in sidebar does not work. #826

donald-pinckney opened this issue Nov 15, 2018 · 0 comments

Comments

@donald-pinckney
Copy link
Contributor

In the past, if you hovered over links in the sidebar, they would be highlighted in blue. This does not work currently. I bisected it, and this behavior change occurred somewhere between b3e0942 (old, has highlighting) and 028c8b0 (new, no highlighting). I couldn't bisect further since the commits in between didn't build.

I'm not sure if this change was intentional or not. I believe it was not intentional and is thus a bug because:

  • That range of commits seemed to be trying to refactor, and no commit messages in there indicated an intent to change a (fairly major) part of the UI experience.
  • Without the highlighting it's pretty hard to tell and unintuitive that the sidebar has links, not just text.

However, I can't be sure that it's not intended behavior.

Dylan-DPC-zz pushed a commit that referenced this issue Apr 23, 2019
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant