Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu bar covers section header on anchor links #1040

Closed
ehuss opened this issue Sep 26, 2019 · 0 comments
Closed

Menu bar covers section header on anchor links #1040

ehuss opened this issue Sep 26, 2019 · 0 comments

Comments

@ehuss
Copy link
Contributor

ehuss commented Sep 26, 2019

When clicking on a section header, it will scroll to the top of the page. However, if the contents sidebar is currently visible, the menu bar at the top of the page covers the section header. Example

mdbook-cover

Here I've reduced the opacity of the menu bar to illustrate that the section header is hidden behind it.

It would be really nice if it scrolled so that the header is below the menu bar.
@mattheww mattheww mentioned this issue Oct 26, 2019
Merged
@ehuss ehuss closed this as completed in 1dc482b Oct 26, 2019
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this issue Aug 30, 2020
@mattheww
Add scroll-margin-top to headings which contain link targets.
99ced51 
This means when the link is followed, the page scrolls in such a way as to
leave space for the fixed menu bar.

Fixes rust-lang#1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ehuss