Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.2] Array size revert #4150

Merged
merged 3 commits into from
Nov 26, 2024
Merged

[0.2] Array size revert #4150

merged 3 commits into from
Nov 26, 2024

Conversation

cramertj
Copy link
Member

These array restructures are breaking changes and should not have landed without a major version bump.

@cramertj
Revert "Fix a few other array size hacks"
24a8e7e 
This reverts commit d63be8b.
@cramertj
Revert "Remove array size hacks for Rust < 1.47"
4dc6a1c 
This reverts commit 27ee6fe.

These array structure changes were breaking changes to the
public API and should not have landed without a major
version bump.
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@cramertj cramertj changed the title Array size revert [0.2] Array size revert Nov 26, 2024
@cramertj
Copy link
Member Author

cc #4062

@Amanieu
Copy link
Member

Amanieu commented Nov 26, 2024

The changes to private fields don't need to be reverted.

@cramertj
Copy link
Member Author

@Amanieu Good point! Fixed.

@tgross35 tgross35 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 795e59a Nov 26, 2024
45 checks passed
@aDotInTheVoid
Copy link
Member

Context: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/libc.20breaking.20change

@GuillaumeGomez
Copy link
Member

Can there be a 0.2.166 release please? :)

@tgross35
Copy link
Contributor

On the way :) #4147

@tgross35
Copy link
Contributor

Released in 0.2.166 https://github.com/rust-lang/libc/releases/tag/0.2.166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@JohnTitor JohnTitor

Labels
O-android O-dragonfly O-gnu O-linux O-macos O-musl O-unix S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cramertj @rustbot @Amanieu @aDotInTheVoid @GuillaumeGomez @tgross35 @JohnTitor