Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests on riscv64gc-unknown-freebsd #4129

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Nov 20, 2024

The fpregs was defined with two fields having the wrong sign, and one field having the wrong name.

Description

Fixes one struct that was defined incorrectly for FreeBSD riscv64

Sources

https://github.com/freebsd/freebsd-src/blob/7a3af393d8ac2dfe72d24fe401344b60c4f87866/sys/riscv/include/ucontext.h#L50

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

The fpregs was defined with two fields having the wrong sign, and one
field having the wrong name.
@tgross35 tgross35 force-pushed the riscv64gc-unknown-freebsd branch from a907982 to 730bf73 Compare November 20, 2024 20:33
@tgross35 tgross35 enabled auto-merge November 20, 2024 20:33
@tgross35
Copy link
Contributor

Do you want this in stable? This seems low risk enough that we could do so.

@asomers
Copy link
Contributor Author

asomers commented Nov 20, 2024

Do you want this in stable? This seems low risk enough that we could do so.

Sure. I'll test it locally first though. This will take about an hour 😢 .

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 20, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into rust-lang:main with commit 91c1297 Nov 20, 2024
45 checks passed
@asomers
Copy link
Contributor Author

asomers commented Nov 20, 2024

@tgross35 tests pass. Go ahead and merge to libc-0.2.

@tgross35
Copy link
Contributor

Thanks, I'll get it in the next round.

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 21, 2024
The fpregs was defined with two fields having the wrong sign, and one
field having the wrong name.

(backport <rust-lang#4129>)
(cherry picked from commit 730bf73)
@tgross35 tgross35 mentioned this pull request Nov 21, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 21, 2024
@asomers asomers deleted the riscv64gc-unknown-freebsd branch November 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-riscv O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants