-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the tests on riscv64gc-unknown-freebsd #4129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
approved these changes
Nov 20, 2024
The fpregs was defined with two fields having the wrong sign, and one field having the wrong name.
tgross35
force-pushed
the
riscv64gc-unknown-freebsd
branch
from
November 20, 2024 20:33
a907982
to
730bf73
Compare
Do you want this in stable? This seems low risk enough that we could do so. |
Sure. I'll test it locally first though. This will take about an hour 😢 . |
tgross35
added
the
stable-nominated
This PR should be considered for cherry-pick to libc's stable release branch
label
Nov 20, 2024
@tgross35 tests pass. Go ahead and merge to libc-0.2. |
Thanks, I'll get it in the next round. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 21, 2024
The fpregs was defined with two fields having the wrong sign, and one field having the wrong name. (backport <rust-lang#4129>) (cherry picked from commit 730bf73)
Merged
tgross35
added
stable-applied
This PR has been cherry-picked to libc's stable release branch
and removed
stable-nominated
This PR should be considered for cherry-pick to libc's stable release branch
labels
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-riscv
O-unix
S-waiting-on-review
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fpregs was defined with two fields having the wrong sign, and one field having the wrong name.
Description
Fixes one struct that was defined incorrectly for FreeBSD riscv64
Sources
https://github.com/freebsd/freebsd-src/blob/7a3af393d8ac2dfe72d24fe401344b60c4f87866/sys/riscv/include/ucontext.h#L50
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI