ci: Ensure build channels get run even if FILTER is unset #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
tgross35
added
the
stable-nominated
In 59a18de("ci: Set `-u` (error on unset)..."), `-u` started being passed to the `set` call in shell scripts. This broke the `FILTER` logic since now the command always fails. Make this a bit less fragile by explicitly setting to an empty string, as well as adding a check that at least one test got run.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
In 59a18de("ci: Set `-u` (error on unset)..."), `-u` started being passed to the `set` call in shell scripts. This broke the `FILTER` logic since now the command always fails. Make this a bit less fragile by explicitly setting to an empty string, as well as adding a check that at least one test got run. (backport <rust-lang#4125>) (cherry picked from commit 084f370)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Nov 20, 2024
(backport <rust-lang#4125>) (cherry picked from commit 907c6d6)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 59a18de("ci: Set
-u(error on unset)..."),-ustarted being passed to thesetcall in shell scripts. This broke theFILTERlogic since now the command always fails.Make this a bit less fragile by explicitly setting to an empty string, as well as adding a check that at least one test got run.