Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openbsd: skip ATF_* constants in CI #4088

Merged
merged 1 commit into from
Nov 18, 2024
Merged

openbsd: skip ATF_* constants in CI #4088

merged 1 commit into from
Nov 18, 2024
+9 −0

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Nov 17, 2024

Description

CI is failing on OpenBSD (due to OpenBSD change).

Some constants (ATF_*) were removed in OpenBSD 7.7 by openbsd/src@ff46e7d

they were unused since 1991.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@semarie
openbsd: skip ATF_* constants in CI
8b3ccdf 
the constants were removed in OpenBSD 7.7 by openbsd/src@ff46e7d
they were unused since 1991.
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35
tgross35 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 18, 2024
@tgross35 tgross35 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into rust-lang:main with commit 0e5e6e2 Nov 18, 2024
44 checks passed
@semarie semarie deleted the openbsd-atf branch November 18, 2024 15:02
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 19, 2024
@semarie @tgross35
openbsd: skip ATF_* constants in CI
3abb0d1 
the constants were removed in OpenBSD 7.7 by openbsd/src@ff46e7d
they were unused since 1991.

(backport <rust-lang#4088>)
(cherry picked from commit 8b3ccdf)
@tgross35 tgross35 mentioned this pull request Nov 19, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semarie @rustbot @tgross35 @JohnTitor