Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check that semver files don't contain duplicate entries #4087

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Add a check that semver files don't contain duplicate entries #4087

merged 1 commit into from
Nov 17, 2024

Conversation

tgross35
Copy link
Contributor

Also make shellcheck failures actually cause an exit, find ... -exec apparently does not propagate errors.

@tgross35
Add a check that semver files don't contain duplicate entries
1568789 
Also make shellcheck failures actually cause an exit, `find ... -exec`
apparently does not propagate errors.
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 17, 2024
@tgross35 tgross35 mentioned this pull request Nov 17, 2024
Merged
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Nov 17, 2024
@tgross35
Add a check that semver files don't contain duplicate entries
c00cc3b 
Also make shellcheck failures actually cause an exit, `find ... -exec`
apparently does not propagate errors.

(backport <rust-lang#4087>)
(cherry picked from commit 1568789)
@tgross35 tgross35 added this pull request to the merge queue Nov 17, 2024
Merged via the queue into rust-lang:main with commit 86b04cb Nov 17, 2024
44 checks passed
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgross35 @rustbot @JohnTitor