-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hurd: cleanups #4029
hurd: cleanups #4029
Conversation
It is not used any more.
Could this also remove |
It is not used.
Sure, done so.
I have to admit I am completely at a loss at what platforms are supposed to export, I have not found a documentation that explains how this is organized. The Linux platform doesn't seem to be exporting |
Line 23 in db36457
ssize_t -> __ssize_t -> __sword_type -> c_int on 32-bit or c_long on 64-bit.
So AIUI, this change is making (cc @sunfishcode since I see you crosslinked an issue) |
Yes, this is reasonable, GNU/Hurd has nothing specific here compared to other unices. |
Since it's needed for rustix, a backport to 0.2 will be useful. |
SGTM, thanks for the follow up
Feel free to just nominate anything that makes sense for a backport, the rustbot command works for everyone. @rustbot label +stable-nominated |
It is not used any more. (backport <rust-lang#4029>) (cherry picked from commit 9f6aa3f)
It is not used. (backport <rust-lang#4029>) (cherry picked from commit e2153f1)
Description
This cleans a couple of details in the hurd port: ssize_t and align are currently not actually used
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI