Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redox: Make ino_t be c_ulonglong #3919

Merged
merged 1 commit into from
Sep 24, 2024
Merged

redox: Make ino_t be c_ulonglong #3919

merged 1 commit into from
Sep 24, 2024

Conversation

jackpot51
Copy link
Contributor

@jackpot51 jackpot51 commented Sep 11, 2024 •
edited
Loading

Corresponding C library change: https://gitlab.redox-os.org/redox-os/relibc/-/commit/4935b981800d978d433cec06e5a371e8c3a2f464

Based on main, but a version for libc-0.2 branch is here: #3918

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jackpot51 jackpot51 mentioned this pull request Sep 11, 2024
Closed
@jackpot51
Copy link
Contributor Author

@tgross35 are there any issues with this PR?

@tgross35
Copy link
Contributor

tgross35 commented Sep 24, 2024 •
edited
Loading

Nothing wrong, the review cycle for libc just tends to be a couple of weeks usually. Change LGTM, thanks for providing a source link!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 24, 2024
@tgross35 tgross35 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into rust-lang:main with commit 7cab757 Sep 24, 2024
41 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@jackpot51 @tgross35
redox: Make ino_t be c_ulonglong (rust-lang#3919)
175fe1a 
(backport <rust-lang#3919>)
(cherry picked from commit 7cab757)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@jackpot51 @tgross35
redox: Make ino_t be c_ulonglong (rust-lang#3919)
3ac320d 
(backport <rust-lang#3919>)
(cherry picked from commit 7cab757)
@tgross35 tgross35 mentioned this pull request Oct 15, 2024
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Oct 15, 2024
@jackpot51 @tgross35
redox: Make ino_t be c_ulonglong (rust-lang#3919)
5921e10 
(backport <rust-lang#3919>)
(cherry picked from commit 7cab757)
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpot51 @rustbot @tgross35