Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: add stabilized HermitOS interface #3766

Closed
wants to merge 2 commits into from

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Jul 6, 2024

HermitOS is a unikernel and its interface to the kernel is provided by https://crates.io/crates/hermit-abi. In the meantime parts of the interface is stabilized and we want to integrated it into libc. Unstable version will be still provided by hermit-abi.

This PR is a backport of #3724 and doesn't have breaking changes. It just provides new functions to enter the kernel.

HermitOS is a unikernel and its interface to the kernel is provided
by https://crates.io/crates/hermit-abi. In the meantime parts of the
interface is stabilized and we want to integrated it into libc.
Unstable version will be still provided by hermit-abi.

Co-authored-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@stlankes stlankes changed the title feat(hermit): add stabilized interface back port: add stabilized interface Jul 8, 2024
@stlankes stlankes changed the title back port: add stabilized interface backport: add stabilized HermitOS interface Jul 8, 2024
@stlankes
Copy link
Contributor Author

I forgot the error numbers and added to this PR.

@JohnTitor
Copy link
Member

Do you think this breaks the existing usage? If so, I'd like to provide this only on 1.0 as it's a breaking change.

@stlankes
Copy link
Contributor Author

stlankes commented Jul 13, 2024

No! I am pretty sure.

@Thomasdezeeuw
Copy link
Contributor

Any update on this? We want to use it Mio as well.

@tgross35
Copy link
Contributor

@stlankes I picked up the first commit as part of my backport bonanza, in #3814. The second commit (5c7c782, "add missing error numbers for HermitOS") seems like it is something that should go to main too. Could you create a new PR targeting main that makes that change? Comment @rustbot label +stable-nominated so it gets picked up in the next backport.

@tgross35
Copy link
Contributor

This can probably just be closed once you create the new one, but

@rustbot author

@bors
Copy link
Contributor

bors commented Aug 13, 2024

☔ The latest upstream changes (presumably #3814) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor

The backport of the first commit merged. I am going to go ahead and close this - but please feel free to put up a new PR with 5c7c782, as mentioned above.

@tgross35 tgross35 closed this Aug 13, 2024
@Thomasdezeeuw
Copy link
Contributor

Thanks @tgross35

@stlankes
Copy link
Contributor Author

stlankes commented Aug 15, 2024

@stlankes I picked up the first commit as part of my backport bonanza, in #3814. The second commit (5c7c782, "add missing error numbers for HermitOS") seems like it is something that should go to main too. Could you create a new PR targeting main that makes that change? Comment @rustbot label +stable-nominated so it gets picked up in the next backport.

I will do it next week. After my vacation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants