Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h #3702

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h #3702

merged 1 commit into from
Aug 13, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented May 15, 2024

Available in the headers on all Apple platforms.

@rustbot
Copy link
Collaborator

rustbot commented May 15, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@madsmtm madsmtm force-pushed the apple-crt-externs branch from 0e391e5 to 11b9d5e Compare May 15, 2024 10:17
@madsmtm
Copy link
Contributor Author

madsmtm commented May 15, 2024

The CI timeout seems to be unrelated

@madsmtm madsmtm force-pushed the apple-crt-externs branch from 11b9d5e to 316c7df Compare May 17, 2024 20:43
@tgross35
Copy link
Contributor

This lgtm, reference here https://opensource.apple.com/source/Libc/Libc-320/include/crt_externs.h.auto.html.

Can you target main? We can backport if needed.

@rustbot label +stable-nominated
@rustbot author

@rustbot rustbot added stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-author and removed S-waiting-on-review labels Aug 12, 2024
@madsmtm madsmtm changed the base branch from libc-0.2 to main August 13, 2024 01:26
@madsmtm
Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h
4333c2f 
Available in the headers on all Apple platforms.
@madsmtm madsmtm force-pushed the apple-crt-externs branch from 316c7df to 4333c2f Compare August 13, 2024 01:29
@madsmtm
Copy link
Contributor Author

madsmtm commented Aug 13, 2024

Can you target main

Sure! @rustbot ready

@tgross35
Copy link
Contributor

Thanks!

@tgross35 tgross35 enabled auto-merge August 13, 2024 01:30
@tgross35 tgross35 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into rust-lang:main with commit 4351675 Aug 13, 2024
39 checks passed
@madsmtm madsmtm deleted the apple-crt-externs branch August 13, 2024 11:47
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 16, 2024
@madsmtm @tgross35
Add _NSGetArgv, _NSGetArgc and _NSGetProgname from crt_externs.h
bff183c 
Available in the headers on all Apple platforms.

(backport <rust-lang#3702>)
(cherry picked from commit 4333c2f)
@tgross35 tgross35 mentioned this pull request Aug 16, 2024
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsmtm @rustbot @tgross35 @JohnTitor