Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding aligned_alloc support for the following: #3698

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

  • linux glibc/musl.
  • all supported BSD implements it.
  • apple.
  • solarish.

close #3689

- linux glibc/musl.
- all supported BSD implements it.
- apple.
- solarish.

close rust-lang#3689
@rustbot
Copy link
Collaborator

rustbot commented May 12, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented May 12, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@safinaskar
Copy link

@devnexen , @JohnTitor , CI is failing in main, and I have some observations.

I made PR #3693 . All checks have passed at some point in interval 11 May 00:28 - 01:29 UTC, so I assume main ( 8b9d1fe ) was okay at that time.

But then at 11 May 18:56 UTC I noticed that very same commit in main ( 8b9d1fe ) has failing CI with platform sparc64-unknown-linux-gnu.

So it seems some external resource was updated, and it broke CI

@devnexen
Copy link
Contributor Author

the sparc container tends to fail from time to time (e.g. timeout)

@safinaskar
Copy link

safinaskar commented May 13, 2024

@devnexen , sparc64 is broken for two days. As you can see, in all PRs for last two days sparc64 did not success.

Also, CI result in this very PR ( #3698 ), says qemu-system-sparc64: terminating on signal 15 from pid 1165 (timeout), but also says /prog: /lib/sparc64-linux-gnu/libm.so.6: version GLIBC_2.38 not found (required by /prog)

( https://github.com/rust-lang/libc/actions/runs/9052276084/job/24869832722?pr=3698 )

@tgross35
Copy link
Contributor

It looks like this is available just about everywhere nowadays:

I can't find the Apple docs, but it seems like this is available in more recent versions. So could this just go in unix/mod.rs?

Also please target main and update the commit message with the changes.

@rustbot author

@devnexen
Copy link
Contributor Author

closed in favor of #3843

@devnexen devnexen closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants