-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the definition of sigevent on FreeBSD and Linux #3630
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
@JohnTitor I fixed the build failure on musl and rebased on main |
The Sparc failure is not due to this PR. |
Considering the main branch is for version 1.0, which allows breaking changes, I think we can move this forward. |
☔ The latest upstream changes (presumably #3962) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased, @tgross35 |
I think the build failure on s390x is unrelated. |
That job seems to fail a lot, I wrote up #4112. Thanks for the changes, I'll take a look today. |
I went through line by line, everything looks correct here but I left a handful of consistency comments. |
☔ The latest upstream changes (presumably #3978) made this pull request unmergeable. Please resolve the merge conflicts. |
I applied your suggestions, @tgross35 , and rebased. But I did not squash the final commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does #3630 (comment) work? If not, a FIXME(ctest)
like the other expressions would be good.
I'll merge tomorrow either way, please squash when you get the chance.
@rustbot label stable-declined (breakage)
This comment was marked as off-topic.
This comment was marked as off-topic.
Whoops. I missed that comment. I've fixed it now. |
It was originally defined back before rust could represent C unions. So instead of defining the union field correctly, it simply defined that union's most useful field. Define it correctly now. Remove traits that can't be safely implemented on a union: PartialEq, Eq, and Hash. Define Debug, but exclude the union field.
Thanks! |
It was originally defined back before rust could represent C unions. So instead of defining the union field correctly, it simply defined that union's most useful field. Define it correctly now.
Remove traits that can't be safely implemented on a union: PartialEq, Eq, and Hash. Define Debug, but exclude the union field. Leave Clone in place.
This PR is a rebase of #2813 that eschews all of the backwards-compatibility parts.