-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GSO flags for linux and android #3405
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Tests were run on Ubuntu 22.04, but its kernel does not support |
☔ The latest upstream changes (presumably #3320) made this pull request unmergeable. Please resolve the merge conflicts. |
If that is the case, it s necessary to put the aforementioned constants as exceptions in the skip_const() helper. |
Could you squash commits into one? |
Though not mentioned in the commit message, change c9643c8 disabled these along with FreeBSD 14.
I will open another PR, I couldn't squash a merge commit in my commits. |
Add Generic Segmentation Offload (GSO) flags based on if_tun.h header in Linux and if_tun.h header in Android source code.
Include the
IFF_NO_CARRIER
flag as well (found in the same files mentioned in the previous paragraph).There is a PR similar to mine, but that PR doesn't include GSO flags for UDP (
TUN_F_USO4
andTUN_F_USO6
), and it is only for Linux. And also, I usedc_uint
type for GSO flags because related ioctl function (#define TUNSETOFFLOAD _IOW('T', 208, unsigned int)
) getunsigned int
but that PR usesc_ushort
.