Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report the actual error when failing to get the rustc version #3000

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 11, 2022

This should help with pinpointing the issue in rust-lang/crater#663.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

👍, @bors r+

@bors
Copy link
Contributor

bors commented Nov 12, 2022

📌 Commit 40c1942 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 12, 2022

⌛ Testing commit 40c1942 with merge bbf929d...

@bors
Copy link
Contributor

bors commented Nov 12, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing bbf929d to master...

@bors bors merged commit bbf929d into rust-lang:master Nov 12, 2022
@bjorn3 bjorn3 deleted the report_rustc_version_errors branch November 12, 2022 08:32
bors added a commit that referenced this pull request Apr 3, 2023
build.rs: print rustc stderr if exit status != 0

I was trying to run benchmarks locally with rustc-perf and found that many of them failed to build with a message from libc's build.rs "Failed to get rustc version." I made this change locally to help debug, and I think it would be generally useful. In my case it quickly revealed that rustc was failing to find libLLVM and so `rustc --version` was emitting nothing on stdout.

I think this may have been part of what was intended with #3000 and might help debug rust-lang/crater#663.
bors added a commit that referenced this pull request Apr 3, 2023
build.rs: print rustc stderr if exit status != 0

I was trying to run benchmarks locally with rustc-perf and found that many of them failed to build with a message from libc's build.rs "Failed to get rustc version." I made this change locally to help debug, and I think it would be generally useful. In my case it quickly revealed that rustc was failing to find libLLVM and so `rustc --version` was emitting nothing on stdout.

I think this may have been part of what was intended with #3000 and might help debug rust-lang/crater#663.
bors added a commit that referenced this pull request Apr 4, 2023
build.rs: print rustc stderr if exit status != 0

I was trying to run benchmarks locally with rustc-perf and found that many of them failed to build with a message from libc's build.rs "Failed to get rustc version." I made this change locally to help debug, and I think it would be generally useful. In my case it quickly revealed that rustc was failing to find libLLVM and so `rustc --version` was emitting nothing on stdout.

I think this may have been part of what was intended with #3000 and might help debug rust-lang/crater#663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants