Add correctly sized structs and types for Android aarch64. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Nercury
force-pushed
the
correctly-sized-structs-and-types-for-android-aarch64
branch
from
01fb15c
to
3ee7182
Compare
Nercury
force-pushed
the
correctly-sized-structs-and-types-for-android-aarch64
branch
from
3ee7182
to
dad0dd2
Compare
bors
added a commit
that referenced
this pull request
May 8, 2016
…droid-aarch64, r=alexcrichton Add correctly sized structs and types for Android aarch64. So far both android x86_64 and aarch64 configurations used incorrect types from 32-bit architecture. This PR updates only the aarch64, because it is more common. The x86_64 may be also incorrect, but is out of scope of this PR.
|
☀️ Test successful - status-appveyor, travis |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 16, 2016
…-abi, r=alexcrichton Update aarch64-linux-android target to match android abi. - Changed `target_env` to "gnu" to empty "" for all android targets because it does not matter for android. - The PR #33048 added "max_atomic_width" for arm-android but missed recently added armv7-android. Add it there too. - Added features `+neon,+fp-armv8` because they [must exist on `aarch64` android](http://developer.android.com/ndk/guides/cpu-features.html). - Update libc to include rust-lang/libc#282 so that rust's std lib works on android's aarch64 (the main issue there was incorrect structure alignment on 64-bit arm). r? @alexcrichton
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Add introduction/constants/enumeration/uninitialized to CONVENTIONS. I have added new sections to the file. I would like the usual suspects to read them critically and offer critique. When have agreed to add certain versions I will add Issues to track our progress in getting the code to follow the conventions. For two of the sections they already exist in rust-lang#254 and rust-lang#264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far both android x86_64 and aarch64 configurations used incorrect types from 32-bit architecture.
This PR updates only the aarch64, because it is more common. The x86_64 may be also incorrect, but is out of scope of this PR.