Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some freebsd private struct fields public and upgrade crate version to 0.2.112 #2590

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 12, 2021

Otherwise we can't use the structs at all...

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez GuillaumeGomez force-pushed the private-fields branch 2 times, most recently from a7c34f1 to d7b1805 Compare December 12, 2021 22:28
@Amanieu
Copy link
Member

Amanieu commented Dec 13, 2021

Can't you use the struct with mem::zeroed, like C code does with memset? Or do you actually need to look at the value of the private field?

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Dec 13, 2021

It is a linked list, I need the next field to be able to get the next element. I also need access to some fields which contain the information I'm looking for. The problem here isn't the initialization (I already used zeroed 😉 ).

@Amanieu
Copy link
Member

Amanieu commented Dec 13, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 13, 2021

📌 Commit 62e20fd has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Dec 13, 2021

⌛ Testing commit 62e20fd with merge 55c44a2...

@bors
Copy link
Contributor

bors commented Dec 13, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 55c44a2 to master...

@bors bors merged commit 55c44a2 into rust-lang:master Dec 13, 2021
@GuillaumeGomez GuillaumeGomez deleted the private-fields branch December 13, 2021 19:08
@GuillaumeGomez
Copy link
Member Author

Can you publish the new version please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants