-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine definition of mcontext_t on x86_64-unknown-linux-musl #1554
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ Thanks! |
📌 Commit e691d94 has been approved by |
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
@gnzlbg thanks for the quick response! When should we expect a release on crates.io? This would help us tremendously! |
I personally would prefer to do so after rust-lang/rust#65469 is merged. That PR is green but apparently blocked by rust-lang/rust#65251 which is being merged right now. The risk of producing new releases of libc in the meantime is that we might have to yank them if upgrading rust discovers newer issues. I'd say let's wait 24h and see if the situation resolves by itself, which it often does, and if it doesn't, then please ping me again here and I'll re-evaluate whether we maybe just do a new release to unblock work on your side or not. If it resolves by itself and I do a new release I will ping you here instead. In the meantime, please use a git dependency on libc master if you want to already use this. The cargo book explains how to |
here's the ping @gnzlbg ! rust-lang/rust#65251 is in and it looks like rust-lang/rust#65469 is ready as well, though bors didn't perform the merge. Unfortunately we can't |
Thanks for the ping, yes everything looks green on their side, so I've released 0.2.65. If something unlikely were to fail on their side, we can always release 0.2.66 with a fix. |
Thanks a bunch! |
Fixes #1553
I've inlined the links I used for defining constants and fields, although they pretty much map to the changes introduced in ac7f0fa and ae06c2b.