Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine definition of mcontext_t on x86_64-unknown-linux-musl #1554

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Refine definition of mcontext_t on x86_64-unknown-linux-musl #1554

merged 2 commits into from
Oct 16, 2019

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Oct 16, 2019

Fixes #1553

I've inlined the links I used for defining constants and fields, although they pretty much map to the changes introduced in ac7f0fa and ae06c2b.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 16, 2019

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 16, 2019

📌 Commit e691d94 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit e691d94 with merge 6dae870...

bors added a commit that referenced this pull request Oct 16, 2019
Refine definition of mcontext_t on x86_64-unknown-linux-musl

Fixes #1553

I've inlined the links I used for defining constants and fields, although they pretty much map to the changes introduced in ac7f0fa and ae06c2b.
@bors
Copy link
Contributor

bors commented Oct 16, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 6dae870 to master...

@bors bors merged commit e691d94 into rust-lang:master Oct 16, 2019
@nmattia nmattia deleted the nm-mcontext branch October 16, 2019 20:12
@nmattia
Copy link
Contributor Author

nmattia commented Oct 16, 2019

@gnzlbg thanks for the quick response! When should we expect a release on crates.io? This would help us tremendously!

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 17, 2019

I personally would prefer to do so after rust-lang/rust#65469 is merged. That PR is green but apparently blocked by rust-lang/rust#65251 which is being merged right now. The risk of producing new releases of libc in the meantime is that we might have to yank them if upgrading rust discovers newer issues.

I'd say let's wait 24h and see if the situation resolves by itself, which it often does, and if it doesn't, then please ping me again here and I'll re-evaluate whether we maybe just do a new release to unblock work on your side or not. If it resolves by itself and I do a new release I will ping you here instead.

In the meantime, please use a git dependency on libc master if you want to already use this. The cargo book explains how to patch dependencies if you don't want to modify your Cargo.toml.

@nmattia
Copy link
Contributor Author

nmattia commented Oct 18, 2019

here's the ping @gnzlbg ! rust-lang/rust#65251 is in and it looks like rust-lang/rust#65469 is ready as well, though bors didn't perform the merge.

Unfortunately we can't patch, as the dependency is then treated as a local crate and we treat warnings as errors.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 18, 2019

Thanks for the ping, yes everything looks green on their side, so I've released 0.2.65. If something unlikely were to fail on their side, we can always release 0.2.66 with a fix.

@nmattia
Copy link
Contributor Author

nmattia commented Oct 18, 2019

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export mcontext fields on x86_64-unknown-linux-musl
4 participants