Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include extra information in metadata comments #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Include extra information in metadata comments #63

wants to merge 2 commits into from

Commits on Aug 16, 2019

  1. Include merge_sha in more metadata comments 

    Include the `merge_sha` in BuildFailed, TryBuildFailed, and TimedOut
metadata comments.

This helps with synchronizing historical data, and will help in the
future correlating which build a failure is associated with.
    @bryanburgers
    bryanburgers committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    823853d View commit details
    Browse the repository at this point in the history

  2. Include start/end times in metadata comments 

    Timing information could be gleaned from comment times, but make it
explicit in the metadata. This means we can get the true times, even if
GitHub has delays.

This also gives us the opportunity to have more control in the future.
For example, the [check_run event][check_run] includes `started_at` and
`completed_at` information that is independent from when GitHub sent us
the webhook.

[check_run]: https://developer.github.com/v3/activity/events/types/#checkrunevent-api-payload
    @bryanburgers
    bryanburgers committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    6c70562 View commit details
    Browse the repository at this point in the history